[PATCH] D95158: Use DataExtractor to decode SLEB128 in android_relas.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 02:24:32 PST 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

In D95158#2524564 <https://reviews.llvm.org/D95158#2524564>, @rahmanl wrote:

> @jhenderson Is this ready to land?

Sorry, I got caught up with things yesterday and didn't get to all the review requests I had to field.

I guess the test case I'm thinking of is showing that the malformed group reloc count value means we don't get the "relocation group unexpectedly large" error. I don't feel strongly enough about this though to push for more testing if you don't want to add it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95158/new/

https://reviews.llvm.org/D95158



More information about the llvm-commits mailing list