[PATCH] D94928: [llvm-mca] Add support for in-order CPUs

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 10:35:56 PST 2021


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/MC/MCSchedule.h:120
   bool     EndGroup : 1;
+  bool     RetireOOO : 1;
   uint16_t WriteProcResIdx; // First index into WriteProcResTable.
----------------
This is a separate problem, but windows builds currently takes 4 bytes for this (before and after this patch) as bool is treated as an int. Would it be possible to change this to:
```
  uint16_t NumMicroOps : 13;
  uint16_t BeginGroup : 1;
  uint16_t EndGroup : 1;
  uint16_t RetireOOO : 1;
```
Ideally replace the bools in an initial patch before this one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94928/new/

https://reviews.llvm.org/D94928



More information about the llvm-commits mailing list