[PATCH] D95321: [NFC] Fixing build warning with llvm-mca

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb accepted this revision.
andreadb added a subscriber: lebedev.ri.
andreadb added a comment.
This revision is now accepted and ready to land.

LGTM.

For the record, that warning was firstly introduced by another commit which was meant to be an NFC refactoring
in preparation for the most recent work that added support for the generation of JSON files.

commit cf6adecd6a8718ee2737ca55e4cd938364b984cc <https://reviews.llvm.org/rGcf6adecd6a8718ee2737ca55e4cd938364b984cc>
`[llvm-mca][NFC] Refactor views to separate data collection from printing.`

That change was reviewed by @lebedev.ri.
Using zip may be sub-optimal because it introduces copies of every MCInst in source.
While it is true that our typical source size is often less than 16, there may be some
rare cases where the source is much larger.
I am not a big fan of using zip in this particular case. However the cost of using zip is probably negligible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95321/new/

https://reviews.llvm.org/D95321