[PATCH] D95509: [AMDGPU] Mark V_SET_INACTIVE as defining SCC
Carl Ritson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 27 03:04:44 PST 2021
critson added inline comments.
================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.set.inactive.ll:28
+; GCN: s_cmp
+; GCN-NOT: s_not
+; GCN: s_cbranch_scc
----------------
foad wrote:
> It's not clear to me what the generated code here looks like, such that it passes these checks. The code generated by globalisel would fail these checks I think.
>
> Maybe autogenerate the checks for this whole file?
I had to change the GlobalISel to a generate file exactly because the output is different.
I can switch this to be generated, which case I'll do it as a pre-commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95509/new/
https://reviews.llvm.org/D95509
More information about the llvm-commits
mailing list