[PATCH] D95509: [AMDGPU] Mark V_SET_INACTIVE as defining SCC

Wed Jan 27 02:53:06 PST 2021

foad added a comment.

Looks fine modulo the inline comment.

================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.set.inactive.ll:28
+; GCN: s_cmp
+; GCN-NOT: s_not
+; GCN: s_cbranch_scc
----------------
It's not clear to me what the generated code here looks like, such that it passes these checks. The code generated by globalisel would fail these checks I think.

Maybe autogenerate the checks for this whole file?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95509/new/

https://reviews.llvm.org/D95509