[PATCH] D86126: Fix issue 47160: "`llvm::is_trivially_copyable` -- static assertion failure after DR 1734"

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 27 02:27:13 PST 2021


serge-sans-paille added inline comments.


================
Comment at: llvm/include/llvm/Support/type_traits.h:182
-                "inconsistent behavior between llvm:: and std:: implementation of is_trivially_copyable");
-#endif
 };
----------------
I understand why you remove this one, but it also removes the only safe guard we had to prevent the ABI issue solved by  https://reviews.llvm.org/D54472. I'm fine with removing it, but only if we add a test case that makes sure that we have a consistent behavior for `llvm::is_trivially_copyable` for most of the ADT containers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86126/new/

https://reviews.llvm.org/D86126



More information about the llvm-commits mailing list