[PATCH] D95490: Support: Extract fs::resize_file_before_mapping_readwrite from FileOutputBuffer

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 19:33:45 PST 2021


dexonsmith added a comment.

In D95490#2524082 <https://reviews.llvm.org/D95490#2524082>, @dexonsmith wrote:

> Note that I have no way of testing this myself on Windows; I'll be checking https://buildkite.com/llvm-project/premerge-checks/builds/23492.

This failed with:

  C:\ws\w1\llvm-project\premerge-checks\llvm\unittests\Support\Path.cpp(1307): error:       Expected: Status.getSize()
  
        Which is: 4096
  
  To be equal to: 123U
  
        Which is: 123

which is the bug I fixed in the update https://reviews.llvm.org/differential/diff/319433/:

In D95490#2524095 <https://reviews.llvm.org/D95490#2524095>, @dexonsmith wrote:

> Fix a copy/paste bug in the test (only observable on Windows).

Anyone know how to trigger a rebuild now that the patch is fixed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95490/new/

https://reviews.llvm.org/D95490



More information about the llvm-commits mailing list