[PATCH] D94954: Fixes Snapdragon Kryo CPU core detection

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D94954#2523988 <https://reviews.llvm.org/D94954#2523988>, @Sonicadvance1 wrote:

> This has mixed signals to me.
> Looking at the recent commits, there is a smattering of commits putting this in the commit message or not.
> Additionally they already have the differential review in the commit messages.
>
> If this is to be enforced, it should first be added to the contributor guide which has nothing on the topic. https://llvm.org/docs/Contributing.html
> And then there should be additional enforcement as a server-side git hook to block this from missing on the server side.

Sorry, it was my mistake. The consensus is to have `Differential Revision: `. `Reviewed by:` is optional. `Reviewers:/Tags:/Subscribers:` cannot be added.

> This is also a minor bugfix that has been merged for nearly a week now. Coming around at this point just to tell me this is just aggressive messaging.

I reported issues to `Reviewed by:` patches equally. I just checked - and this commit message is good. But for others, it is not late to tell them to improve for future commits. (And many people may not read relevant sentences https://llvm.org/docs/Contributing.html )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94954/new/

https://reviews.llvm.org/D94954