[PATCH] D94954: Fixes Snapdragon Kryo CPU core detection

Ryan Houdek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 15:31:46 PST 2021


Sonicadvance1 added a comment.

This has mixed signals to me.
Looking at the recent commits, there is a smattering of commits putting this in the commit message or not.
Additionally they already have the differential review in the commit messages.

If this is to be enforced, it should first be added to the contributor guide which has nothing on the topic. https://llvm.org/docs/Contributing.html
And then there should be additional enforcement as a server-side git hook to block this from missing on the server side.

This is also a minor bugfix that has been merged for nearly a week now. Coming around at this point just to tell me this is just aggressive messaging.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94954/new/

https://reviews.llvm.org/D94954



More information about the llvm-commits mailing list