[PATCH] D95209: [CodeGen] Port Machine Function Splitter from ELF to COFF

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish requested changes to this revision.
snehasish added a comment.
This revision now requires changes to proceed.

IMHO we should not ship the split functions feature targeting COFF without more testing. The machine function splitter relies on basic block sections and we should ensure that the debug information/call frame information generated by basic block sections is appropriate for COFF based consumers. Perhaps we can start by extending the existing CFI and DebugInfo tests in `llvm/test/CodeGen/X86/cfi-basic-block-sections-1.ll` and `llvm/test/DebugInfo/X86/basic-block-sections_1.ll` (in a separate patch).

We are also very interested in having this work on windows targets such as Chromium so your initiative here is appreciated!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95209/new/

https://reviews.llvm.org/D95209