[PATCH] D95209: [CodeGen] Port Machine Function Splitter from ELF to COFF

Mon Jan 25 18:27:08 PST 2021

TaoPan added a comment.

Thanks for your review comment!
I don’t have any more detail information about COFF versus ELF difference with regards to DebugInfo and CFI handling.
I used this patch to build my c micro case, workable.
Is it ok that improves this feature by issue driven as it’s default off?
I’ll try to enable this feature to build some complex application, e.g. chromium windows, improve this feature if there are any issues.

================
Comment at: llvm/lib/CodeGen/BasicBlockSections.cpp:84
 // profiles and allows optimizations such as hugepage mapping to be applied at a
 // section granularity. Defaults to ".text.split." which is recognized by lld
 // via the `-z keep-text-section-prefix` flag.
----------------
tmsriram wrote:
> Maybe fix the comment too.
Fixed, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95209/new/

https://reviews.llvm.org/D95209