[PATCH] D95025: [RISCV] Add a test showing incorrect codegen

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

In D95025#2522284 <https://reviews.llvm.org/D95025#2522284>, @frasercrmck wrote:

> Yes, we're certainly not moving away from `update_llc_test_checks.py` for the vector tests; I've used it in all of my work thus far. This test doesn't work perfectly with either the `llc` or `mir` scripts because it's IR -> MIR. The `llc` script does nothing on this test.
>
> The `mir` script is more complicated, as it was used to generate the function checks in this MIR but it doesn't output anything for the YAML. So I had to add checks for the stack objects myself. I didn't want to include `Assertions have been autogenerated by blah` if it wasn't 100% auto-generated as it would give someone the impression they can just run the script again to regenerate the output. So I removed it. However, maybe the better approach would be to keep that line in but add an additional comment explaining this?

Hm, I guess ideally we'd have an option for update_mir_test_checks.py to emit the stack info. I'll see if I can do that later today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95025/new/

https://reviews.llvm.org/D95025