[PATCH] D95234: [RISCV] Define different pseudo instructions for different FPR.

Mon Jan 25 23:48:04 PST 2021

HsiangKai added a comment.

In D95234#2520781 <https://reviews.llvm.org/D95234#2520781>, @craig.topper wrote:

> Is this patch really dependent on frame lowering and spilling or can we land this before the branch tomorrow?
>
> It's looking like we may have to cherry pick frame lowering and spilling after the branch. So if this patch isn't dependent we should go ahead so we don't have to cherry pick it too.

I will land this patch first.

================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:4195
+            (!cast<Instruction>("PseudoVFMV_V_F_" #
+                                !cond(!eq(fvti.Scalar, f16): "F16_",
+                                      !eq(fvti.Scalar, f32): "F32_",
----------------
frasercrmck wrote:
> How come you're not using `GetScalarSuffix` in these cases too?
getScalarSuffix() may need to be defined in more general way.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95234/new/

https://reviews.llvm.org/D95234