[PATCH] D94465: [RISCV] Frame handling for RISC-V V extension. (2nd. version)

[Hsiangkai Wang via Phabricator via llvm-commits]

HsiangKai marked 5 inline comments as done.
HsiangKai added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:556
 
-  const auto &CSI = getNonLibcallCSI(MFI.getCalleeSavedInfo());
+  const auto &CSI = getNonLibcallCSI(MF, MFI.getCalleeSavedInfo());
 
----------------
jrtc27 wrote:
> jrtc27 wrote:
> > Caller can do `MF.getFrameInfo().getCalleeSaveInfo()` now, no need to pass it.
> Eh, I guess sometimes it's already lying around, and there's a lot of redundancy in some of the arguments passed around elsewhere.
I prefer to keep it as so in this patch.


================
Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp:237
+
+    // Scalable load/store has no immediate field.
+    if (MFI.getStackID(FrameIndex) == TargetStackID::ScalableVector &&
----------------
jrtc27 wrote:
> This step doesn't get a number/summary?
I didn't understand this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94465/new/

https://reviews.llvm.org/D94465