[PATCH] D93694: [MachineLICM][MachineSink] Move SinkIntoLoop from MachineLICM to MachineSink

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 08:09:37 PST 2021


SjoerdMeijer updated this revision to Diff 319014.
SjoerdMeijer added a comment.
Herald added a subscriber: pengfei.

Thanks, this now:

- breaks if we can't sink an instruction,
- and I have removed `test/CodeGen/X86/sink-cheap-instructions.ll` as that has no value anymore; this has been integrated as a MIR test and keeping this IR test  around doesn't add anything at this point. When this loop sinking starts doing something useful and correct, better target tests need to be added.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93694/new/

https://reviews.llvm.org/D93694

Files:
  llvm/lib/CodeGen/MachineLICM.cpp
  llvm/lib/CodeGen/MachineSink.cpp
  llvm/test/CodeGen/AArch64/loop-sink.mir
  llvm/test/CodeGen/X86/sink-cheap-instructions.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93694.319014.patch
Type: text/x-patch
Size: 50947 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210125/807e069a/attachment.bin>


More information about the llvm-commits mailing list