[PATCH] D95289: [TargetLowering][RISCV] Don't turn (seteq/ne (sext_inreg X, VT), C1) -> (seteq/ne (zext_inreg X, VT), C1) if the sext_inreg is cheaper

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 25 02:34:23 PST 2021


jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/double-stack-spill-restore.ll:22
 ; RV32IFD-NEXT:    fsd ft0, 8(sp) # 8-byte Folded Spill
-; RV32IFD-NEXT:    call func
+; RV32IFD-NEXT:    call func at plt
 ; RV32IFD-NEXT:    sw a0, 16(sp)
----------------
frasercrmck wrote:
> I'm not familiar with this syntax: is this just a result of running the `update_llc_test_checks.py` script, and given that `call func` matches `call func at plt` it was passing anyway?
Yes, these check lines just predate full PIC support


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95289/new/

https://reviews.llvm.org/D95289



More information about the llvm-commits mailing list