[PATCH] D95312: [TableGen] [DetailedRecords] Print record name that is null string as ""

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added a comment.

I think the only test that would make sense is a FileCheck test. Of course, that's the only kind of test I've written, so I might be deluding myself.

The problem with a FileCheck test is that it relies on the precise format of the output, which is why the default print records backend of TableGen can never be changed. I'd hate to make DetailedRecords' output rigid like that, because it was written precisely to produce a more detailed dump of the TableGen data in a somewhat friendlier format.

I could write a simple test that just checks that all the global variables, classes, and records are at least included in the output, if not their precise format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95312/new/

https://reviews.llvm.org/D95312