[PATCH] D95312: [TableGen] [DetailedRecords] Print record name that is null string as ""

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D95312#2518598 <https://reviews.llvm.org/D95312#2518598>, @Paul-C-Anagnostopoulos wrote:

> Yes, of course, empty().
>
> Are you asking whether there is a test for this change?

I'm requesting a test be included with/for this change, yeah.

> There is no test at all for the DetailedRecord backend, just as there is no test for the default print backend. Do you think there should be tests for those two backends?

Sounds like it - I don't know too much about tablegen, perhaps there's some particular reason not to test these things (perhaps testing them would be difficult to the point of not being worthwhile,etc) - but if there's no particular reason not to, yeah, this should be tested in some way. I don't have strong feelings about what way (API unit test (gtest), lit test, etc) it is tested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95312/new/

https://reviews.llvm.org/D95312