[PATCH] D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

In D95184#2517508 <https://reviews.llvm.org/D95184#2517508>, @clemenswasser wrote:

> You should also change `compiler-rt/lib/asan/asan_win.cpp` like this:
>
>   diff --git a/compiler-rt/lib/asan/asan_win.cpp b/compiler-rt/lib/asan/asan_win.cpp
>   index 8044ae16ff9b..1577c83cf994 100644
>   --- a/compiler-rt/lib/asan/asan_win.cpp
>   +++ b/compiler-rt/lib/asan/asan_win.cpp
>   @@ -134,7 +134,7 @@ INTERCEPTOR(int, _except_handler4, void *a, void *b, void *c, void *d) {
>    static thread_return_t THREAD_CALLING_CONV asan_thread_start(void *arg) {
>      AsanThread *t = (AsanThread *)arg;
>      SetCurrentThread(t);
>   -  return t->ThreadStart(GetTid(), /* signal_thread_is_registered */ nullptr);
>   +  return t->ThreadStart(GetTid());
>    }
>   
>    INTERCEPTOR_WINAPI(HANDLE, CreateThread, LPSECURITY_ATTRIBUTES security,

Thanks. Sorry for breaking the Windows build. This should be resolved by 757b93bb7b384038a8dec35433f78f5c7c2ef8b0 <https://reviews.llvm.org/rG757b93bb7b384038a8dec35433f78f5c7c2ef8b0>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95184/new/

https://reviews.llvm.org/D95184