[PATCH] D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor.

Clemens Wasser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 23 06:43:08 PST 2021


clemenswasser added a comment.

You should also change `compiler-rt/lib/asan/asan_win.cpp` like this:

  diff --git a/compiler-rt/lib/asan/asan_win.cpp b/compiler-rt/lib/asan/asan_win.cpp
  index 8044ae16ff9b..1577c83cf994 100644
  --- a/compiler-rt/lib/asan/asan_win.cpp
  +++ b/compiler-rt/lib/asan/asan_win.cpp
  @@ -134,7 +134,7 @@ INTERCEPTOR(int, _except_handler4, void *a, void *b, void *c, void *d) {
   static thread_return_t THREAD_CALLING_CONV asan_thread_start(void *arg) {
     AsanThread *t = (AsanThread *)arg;
     SetCurrentThread(t);
  -  return t->ThreadStart(GetTid(), /* signal_thread_is_registered */ nullptr);
  +  return t->ThreadStart(GetTid());
   }
  
   INTERCEPTOR_WINAPI(HANDLE, CreateThread, LPSECURITY_ATTRIBUTES security,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95184/new/

https://reviews.llvm.org/D95184



More information about the llvm-commits mailing list