[PATCH] D95150: [RISCV] Add B extension tests to make sure RV64 only instructions aren't accepted in RV32.

Fri Jan 22 11:30:15 PST 2021

jrtc27 added a comment.

In D95150#2516166 <https://reviews.llvm.org/D95150#2516166>, @craig.topper wrote:

> In D95150#2516111 <https://reviews.llvm.org/D95150#2516111>, @asb wrote:
>
>> Thanks for extending the test coverage!
>>
>> Given that other than RVC, the RV64 variants of instruction set extensions are always additive, I have a slight preference for just adding some RV64 RUN lines to the rv32*-valid.s tests rather than copying and pasting the common instructions to the rv64*-valid.s files. This is consistent with what we do for the base extensions.
>>
>> But this works fine, so I'm happy enough for it to land as is.
>
> zext.h and rev8 from Zbb have different encodings between rv32 and rv64. Should we use different check prefixes for those?

For RVC we have an rv32c-only-valid.s to avoid the need to mess with check prefixes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95150/new/

https://reviews.llvm.org/D95150