[PATCH] D95150: [RISCV] Add B extension tests to make sure RV64 only instructions aren't accepted in RV32.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 11:15:01 PST 2021


craig.topper added a comment.

In D95150#2516111 <https://reviews.llvm.org/D95150#2516111>, @asb wrote:

> Thanks for extending the test coverage!
>
> Given that other than RVC, the RV64 variants of instruction set extensions are always additive, I have a slight preference for just adding some RV64 RUN lines to the rv32*-valid.s tests rather than copying and pasting the common instructions to the rv64*-valid.s files. This is consistent with what we do for the base extensions.
>
> But this works fine, so I'm happy enough for it to land as is.

zext.h and rev8 from Zbb have different encodings between rv32 and rv64. Should we use different check prefixes for those?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95150/new/

https://reviews.llvm.org/D95150



More information about the llvm-commits mailing list