[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added inline comments.


================
Comment at: clang/include/clang/Basic/riscv_vector.td:144
+  // This builtin has a masked form.
+  bit HasMask = 1;
+
----------------
May I recommend that you use 'true' and 'false' for boolean literals.


================
Comment at: clang/include/clang/Basic/riscv_vector.td:190
+        defvar suffix = !head(!tail(s_p));
+        defvar prototype = !head(!tail(!tail(s_p)));
+
----------------
If you find it clearer, you can code !head(s_p[1]) and !head(s_p[2]).

TableGen needs an !element() operator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95016/new/

https://reviews.llvm.org/D95016