[PATCH] D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

Ping - this one has had a lot of discussion, and I think all of the substantial concerns have been addressed; are there any further comments?

W.r.t the replacement of `DBG_VALUE` with `DBG_VALUE_LIST`, the current plan is to make that all happen in a patch following this stack. The patch itself should mostly be deletion of old code and simplifying where possible, renaming `DBG_VALUE_LIST` to `DBG_VALUE`, adding an extra operand to the new `DBG_VALUE` to represent directness, adding several tests, and updating existing tests as appropriate. It's not a no-op, but it should be relatively simple to review since there's little to no "new logic" being added; it will however involve updating a large amount of code and be more "disruptive" than this patch, since it will be likely to break private code changes and tests relating to `DBG_VALUE`s. It makes more sense to land the existing patches before pushing the update for this reason. I was originally also planning to add the new operand as part of this patch, but since it would have no effect, I believe it would be better to add in a followup patch instead of adding an operand that is never actually read at any point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82363/new/

https://reviews.llvm.org/D82363