[PATCH] D94822: [TableGen] Improve algorithm for inheriting class template arguments and fields

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/TableGen/TGParser.cpp:2612
+    BadField = AddValue(CurRec, IdLoc,
+                         RecordVal(DeclName, IdLoc, Type,
+                                   HasField ? RecordVal::FK_NonconcreteOK
----------------
craig.topper wrote:
> Paul-C-Anagnostopoulos wrote:
> > craig.topper wrote:
> > > Please run clang-format
> > I've never run it. Doesn't it reformat the entire file?
> You can run it on only the things changed by your commit by doing this
> 
> ```
> git diff -U0 --no-color HEAD^ | clang-format-diff.py -i -p1
> ```
> 
> I think clang-format-diff is in clang/tools/clang-format in your source tree. There's a -binary option to give it the path to the clang-format binary if its not in your path.
> 
> https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting
> 
If clang/tools/clang-format/git-clang-format is on your path then you can run `git clang-format HEAD^` to only reformat lines that are touched by your topmost commit, then `git commit -a --amend --no-edit` to incorporate the changes that clang-format made if you like.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94822/new/

https://reviews.llvm.org/D94822