[PATCH] D95217: [LoopVectorize] Fix VPRecipeBuilder::createEdgeMask to correctly generate the mask

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune added a comment.

In D95217#2515062 <https://reviews.llvm.org/D95217#2515062>, @uabelho wrote:

> Thanks for fixing this!
> I don't know this code at all, but I'm puzzled by this sentence in the summary:
>
>> The path for.body -> cond.false -> cond.end should be taken when 'select i1 true, i1 poison, i1 false' holds
>
> So, the path described above is what should indeed be executed, but you say it should be taken when "'select i1 true, i1 poison, i1 false' holds"?
> But that select returns poison? I really don't understand this.

That was my epic typo, sorry. It should have been `select i1 false, i1 poison, i1 false` because the buggy case was encoding the path that visits `cond.false`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95217/new/

https://reviews.llvm.org/D95217