[PATCH] D95217: [LoopVectorize] Fix VPRecipeBuilder::createEdgeMask to correctly generate the mask

Mikael Holmén via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 03:06:30 PST 2021


uabelho added a comment.

Thanks for fixing this!
I don't know this code at all, but I'm puzzled by this sentence in the summary:

> The path for.body -> cond.false -> cond.end should be taken when 'select i1 true, i1 poison, i1 false' holds

So, the path described above is what should indeed be executed, but you say it should be taken when "'select i1 true, i1 poison, i1 false' holds"?
But that select returns poison? I really don't understand this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95217/new/

https://reviews.llvm.org/D95217



More information about the llvm-commits mailing list