[PATCH] D94480: [NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 22 01:25:24 PST 2021


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

> but someone who knows AArch should comment.

Sorry, I had no idea what this was and what it was doing. I see now, and this does indeed look like an NFC.

It turns out that on AArch64 it is controlled by a subtarget feature that is never enabled, so won't be used without being forced. Not handling IEEE denomal inputs might be a mistake, I'm not sure. This patch is an NFC in that regards though.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94480/new/

https://reviews.llvm.org/D94480



More information about the llvm-commits mailing list