[PATCH] D94480: [NFC] [DAGCombine] Correct the result for sqrt even the iteration is zero

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added a comment.

> The bif/bic difference seems logically fine and probably better overall since we're using less registers, but someone who knows AArch should comment.
> Also, it would be interesting to know why the code changed because we are seemingly producing the same set of SDNode ops? There might be another combine/lowering opportunity.

This is a good example to show how important the code review is and thank you for pointing out this. I should have realized it as it should be a NFC patch. The reason why you see the test change is that, AArch64 don't want the zero if it is denormal input while the default implementation return zero if it is denormal input. I miss to override it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94480/new/

https://reviews.llvm.org/D94480