[PATCH] D86644: [llvm-mca] Initial implementation of output serialization using JSON

[Wolfgang Pieb via Phabricator via llvm-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG04af1ca2e908: [llvm-mca] Forgot a couple of override specifiers. (authored by wolfgangp).

Changed prior to commit:
  https://reviews.llvm.org/D86644?vs=318269&id=318337#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86644/new/

https://reviews.llvm.org/D86644

Files:
  llvm/tools/llvm-mca/Views/InstructionView.h


Index: llvm/tools/llvm-mca/Views/InstructionView.h
===================================================================
--- llvm/tools/llvm-mca/Views/InstructionView.h
+++ llvm/tools/llvm-mca/Views/InstructionView.h
@@ -34,16 +34,19 @@
   mutable raw_string_ostream InstrStream;
 
 public:
-  void printView(llvm::raw_ostream &) const {}
+  void printView(llvm::raw_ostream &) const override {}
   InstructionView(const llvm::MCSubtargetInfo &STI,
                   llvm::MCInstPrinter &Printer,
                   llvm::ArrayRef<llvm::MCInst> S,
                   StringRef MCPU = StringRef())
-      : STI(STI), MCIP(Printer), Source(S), MCPU(MCPU), InstrStream(InstructionString) {}
+      : STI(STI), MCIP(Printer), Source(S), MCPU(MCPU),
+        InstrStream(InstructionString) {}
 
   virtual ~InstructionView() = default;
 
-  StringRef getNameAsString() const { return "Instructions and CPU resources"; }
+  StringRef getNameAsString() const override {
+    return "Instructions and CPU resources";
+  }
   // Return a reference to a string representing a given machine instruction.
   // The result should be used or copied before the next call to
   // printInstructionString() as it will overwrite the previous result.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86644.318337.patch
Type: text/x-patch
Size: 1231 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210121/921a5e71/attachment.bin>