[PATCH] D86644: [llvm-mca] Initial implementation of output serialization using JSON

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added a comment.

FYI I'm seeing clang diagnostic errors, I think from this commit:

> Views/InstructionView.h:37:8: error: 'printView' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
>
>   void printView(llvm::raw_ostream &) const {}
>        ^
>
> Views/View.h:37:16: note: overridden virtual function is here
>
>   virtual void printView(llvm::raw_ostream &OS) const = 0;
>                ^
>
> In file included from llvm-project/llvm/tools/llvm-mca/Views/BottleneckAnalysis.cpp:15:
> In file included from llvm-mca-headers/Views/BottleneckAnalysis.h:83:
> Views/InstructionView.h:46:13: error: 'getNameAsString' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
>
>   StringRef getNameAsString() const { return "Instructions and CPU resources"; }
>             ^
>
> Views/View.h:44:21: note: overridden virtual function is here
>
>   virtual StringRef getNameAsString() const = 0;




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86644/new/

https://reviews.llvm.org/D86644