[PATCH] D94984: [AIX] simplify xcoff part of function TargetMachine::shouldAssumeDSOLocal()

Digger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 13:49:39 PST 2021


DiggerLin updated this revision to Diff 318309.
DiggerLin marked an inline comment as done.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94984/new/

https://reviews.llvm.org/D94984

Files:
  llvm/lib/Target/TargetMachine.cpp


Index: llvm/lib/Target/TargetMachine.cpp
===================================================================
--- llvm/lib/Target/TargetMachine.cpp
+++ llvm/lib/Target/TargetMachine.cpp
@@ -149,12 +149,8 @@
     return GV->isStrongDefinitionForLinker();
   }
 
-  // Due to the AIX linkage model, any global with default visibility is
-  // considered non-local.
-  if (TT.isOSBinFormatXCOFF())
-    return false;
-
-  assert(TT.isOSBinFormatELF() || TT.isOSBinFormatWasm());
+  assert(TT.isOSBinFormatELF() || TT.isOSBinFormatWasm() ||
+         TT.isOSBinFormatXCOFF());
   assert(RM != Reloc::DynamicNoPIC);
   return false;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94984.318309.patch
Type: text/x-patch
Size: 630 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210121/200ba7ac/attachment.bin>


More information about the llvm-commits mailing list