[PATCH] D94931: [RISCV] Add attribute support for all supported extensions

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/attributes.ll:49
 ; RV32C: .attribute 5, "rv32i2p0_c2p0"
+; RV32B: .attribute 5, "rv32i2p0_b0p92_zbb0p92_zbc0p92_zbe0p92_zbf0p92_zbm0p92_zbp0p92_zbr0p92_zbs0p92_zbt0p92"
+; RV32V: .attribute 5, "rv32i2p0_v0p9"
----------------
asb wrote:
> I suppose given the way this works in LLVM it would add even more duplication to reverse the logic for enabling sub-extensions and specify only `rv32i2p0_b0p92`, but @kito-cheng, can you please confirm what GCC does in a case like this?
A single (extension -> extension list) list for all the implications would work for both uses I think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94931/new/

https://reviews.llvm.org/D94931