[PATCH] D94230: [AArch64][SVE] Add SVE IR pass to coalesce ptrue instrinsic calls

Joe Ellis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 20 08:35:46 PST 2021


joechrisellis added a comment.

Thanks for the comments @fhahn! 😄



================
Comment at: llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp:263
+  for (auto *F : Functions) {
+    for (auto &BB : *F) {
+      SmallSetVector<IntrinsicInst *, 4> SVAllPTrues;
----------------
fhahn wrote:
> you just need to iterate over all instructions in a function, right? There's `instruction(F)` which does so directly.
These are looking at basic-block local ptrue intrinsic calls at the minute -- we're passing the basic block to coalescePTrueIntrinsicCalls below too. 🙂 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94230/new/

https://reviews.llvm.org/D94230



More information about the llvm-commits mailing list