[PATCH] D94968: [flang][driver] Move isFixedFormSuffix and isFreeFormSuffix to flangFrontend
Andrzej Warzynski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 19 06:28:35 PST 2021
awarzynski created this revision.
Herald added a reviewer: sscalpone.
awarzynski requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
As highlighted in the post-commit review:
- https://reviews.llvm.org/D94228,
isFixedFormSuffix and isFreeFormSuffix should be defined in
flangFrontend rather than flangFrontendTool library. That's for 2
reasons:
- these methods are used in flangFrontend rather than flangFrontendTool
- flangFrontendTool depends on flangFrontend
As mentioned on D94228 <https://reviews.llvm.org/D94228>, without this change shared library builds fails.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D94968
Files:
flang/include/flang/Frontend/FrontendOptions.h
flang/include/flang/FrontendTool/Utils.h
flang/lib/Frontend/FrontendAction.cpp
flang/lib/Frontend/FrontendOptions.cpp
flang/lib/FrontendTool/ExecuteCompilerInvocation.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94968.317545.patch
Type: text/x-patch
Size: 4503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210119/8be62187/attachment.bin>
More information about the llvm-commits
mailing list