[PATCH] D94895: [X86] Add experimental option to separately tune alignment of innermost loops

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 20 05:21:44 PST 2021


pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:51631
+    return Align(1ULL << ExperimentalPrefInnermostLoopAlignment);
+  return TargetLowering::getPrefLoopAlignment();
+}
----------------
mkazantsev wrote:
> pengfei wrote:
> > Should it be `Align(1ULL << ExperimentalPrefLoopAlignment)`?
> This is already stored in PrefLoopAlignment field. See usages of this option in code. IMO usage of default implementation is better than code copy-paste.
I see. Thank you.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94895/new/

https://reviews.llvm.org/D94895



More information about the llvm-commits mailing list