[PATCH] D94895: [X86] Add experimental option to separately tune alignment of innermost loops

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 20:26:23 PST 2021


mkazantsev added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:51631
+    return Align(1ULL << ExperimentalPrefInnermostLoopAlignment);
+  return TargetLowering::getPrefLoopAlignment();
+}
----------------
pengfei wrote:
> Should it be `Align(1ULL << ExperimentalPrefLoopAlignment)`?
This is already stored in PrefLoopAlignment field. See usages of this option in code. IMO usage of default implementation is better than code copy-paste.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94895/new/

https://reviews.llvm.org/D94895



More information about the llvm-commits mailing list