[PATCH] D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter
Zixuan Wu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 20 02:54:20 PST 2021
zixuan-wu added a comment.
In D93798#2506428 <https://reviews.llvm.org/D93798#2506428>, @rengolin wrote:
> Hi Zixuan,
>
> I'm still worried about the `n` in 4/n and 5/n. I know these are not the final patches of the back-end, but we need a minimal structure of the first batch, just like we have for m68k at the moment.
>
> Can you isolate a first batch of patches that'd make the CSKY back-end generate ASM code for some basic code generation example (like `foo(a, b) { return a+b }`)?
>
> Those would be a first import, and will give reviewers the chance to understand your whole approach, not only one step into the future.
>
> I think this is what's keeping people from reviewing your patches...
>
> cheers,
> --renato
Yes, a first batch of patches to reach the point that it can generate first ALU asm codegen. In all, I propose following patches to construct the first batch.
https://reviews.llvm.org/D93798
https://reviews.llvm.org/D94007
https://reviews.llvm.org/D95029
https://reviews.llvm.org/D95030
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93798/new/
https://reviews.llvm.org/D93798
More information about the llvm-commits
mailing list