[PATCH] D93798: [CSKY 4/n] Add basic CSKYAsmParser and CSKYInstPrinter

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 03:49:36 PST 2021


rengolin added a comment.

Hi Zixuan,

I'm still worried about the `n` in 4/n and 5/n. I know these are not the final patches of the back-end, but we need a minimal structure of the first batch, just like we have for m68k at the moment.

Can you isolate a first batch of patches that'd make the CSKY back-end generate ASM code for some basic code generation example (like `foo(a, b) { return a+b }`)?

Those would be a first import, and will give reviewers the chance to understand your whole approach, not only one step into the future.

I think this is what's keeping people from reviewing your patches...

cheers,
--renato


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93798/new/

https://reviews.llvm.org/D93798



More information about the llvm-commits mailing list