[PATCH] D88391: [M68k] (Patch 5/8) Target lowering

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kSubtarget.h:83
+  bool isM68040() const { return SubtargetKind >= M40; }
+  bool isM68060() const { return SubtargetKind >= M60; }
+
----------------
myhsu wrote:
> RKSimon wrote:
> > Not sure if the naming here is correct - the function name suggests a specific CPU, but the implementation suggests a minimum CPU feature set.
> good point...what about `asM680x0()`? I was thinking `atLeastM680x0()` but sounds a little cumbersome
atLeastM68020() sounds ok (assuming it doesn't screw up a load of formatting, line spill etc.).

An alternative is something like:
```
bool hasMinimumCPUVersion(enum M68kSubtargetKind);
```




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88391/new/

https://reviews.llvm.org/D88391