[PATCH] D88391: [M68k] (Patch 5/8) Target lowering

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 20 00:45:07 PST 2021


myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kSubtarget.h:83
+  bool isM68040() const { return SubtargetKind >= M40; }
+  bool isM68060() const { return SubtargetKind >= M60; }
+
----------------
RKSimon wrote:
> Not sure if the naming here is correct - the function name suggests a specific CPU, but the implementation suggests a minimum CPU feature set.
good point...what about `asM680x0()`? I was thinking `atLeastM680x0()` but sounds a little cumbersome


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88391/new/

https://reviews.llvm.org/D88391



More information about the llvm-commits mailing list