[PATCH] D94951: [RISCV] refactor VPatBinary (NFC)

Tue Jan 19 18:57:10 PST 2021

craig.topper added a comment.

In D94951#2508538 <https://reviews.llvm.org/D94951#2508538>, @arcbbb wrote:

> In D94951#2507301 <https://reviews.llvm.org/D94951#2507301>, @craig.topper wrote:
>
>> I'm not sure I understand what's special about vrgathere16 that needs this refactor. Can you provide an explanation?
>
> VPatBinary helps encode LMUL in the instruction name,
> but for vrgatherei16 it needs to encode both LMUL & EMUL in the instruction name,
> like `PseudoVRGATHEREI16_VV_M1_M1`, and `PseudoVRGATHEREI16_VV_M1_M2`.
> Here is my patch for vrgatherei16 based on the NFC patch https://reviews.llvm.org/D95014

ok that makes sense. thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94951/new/

https://reviews.llvm.org/D94951