[PATCH] D94982: [NPM][Inliner] Factor ImportedFunctionStats in the InlineAdvisor

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/Analysis/InlineAdvisor.h:170
 
+  Module &M;
   FunctionAnalysisManager &FAM;
----------------
mtrofin wrote:
> aeubanks wrote:
> > mtrofin wrote:
> > > aeubanks wrote:
> > > > is this used anywhere except the constructor?
> > > MLInlineAdvisor, which had this member as a protected, and now is using this instead.
> > I tried removing the variable from MLInlineAdvisor and it still compiled.
> You need to build with the optional tensorflow dependencies. For uses of M, see: MLinlineAdvisor::onPassEntry, or DevelopmentModeMLInlineAdvisor::getTotalSizeEstimate
Ah sorry I missed that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94982/new/

https://reviews.llvm.org/D94982