[PATCH] D94982: [NPM][Inliner] Factor ImportedFunctionStats in the InlineAdvisor

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 17:21:37 PST 2021


mtrofin marked an inline comment as done.
mtrofin added inline comments.


================
Comment at: llvm/include/llvm/Analysis/InlineAdvisor.h:170
 
+  Module &M;
   FunctionAnalysisManager &FAM;
----------------
aeubanks wrote:
> mtrofin wrote:
> > aeubanks wrote:
> > > is this used anywhere except the constructor?
> > MLInlineAdvisor, which had this member as a protected, and now is using this instead.
> I tried removing the variable from MLInlineAdvisor and it still compiled.
You need to build with the optional tensorflow dependencies. For uses of M, see: MLinlineAdvisor::onPassEntry, or DevelopmentModeMLInlineAdvisor::getTotalSizeEstimate


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94982/new/

https://reviews.llvm.org/D94982



More information about the llvm-commits mailing list