[PATCH] D94266: [polly][NewPM][test] Fix polly tests under -enable-new-pm

Tue Jan 19 12:22:50 PST 2021

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

Note that for same passes, there Polly has NPM equivalents. E.g. `-polly-prepare` has `-passes=polly-prepare`, `-polly-scops` has `-passes='scop(print<polly-scops>)'`.

Assuming this is the accepted workaround for the NPM transition (I personally think it is ugly), this looks fine for the Polly side of things.

================
Comment at: llvm/tools/opt/opt.cpp:484
+      "thumb2-", "arm-",   "si-",        "gcn-",     "amdgpu-", "aarch64-",
+      "amdgcn-", "polly-", "polyhedral-"};
   std::vector<StringRef> PassNameContain = {"ehprepare"};
----------------
The only pass with `polyhedral-` prefix is `polyhedral-info`, i.e. could be added to `PassNameExact`.

================
Comment at: polly/test/ScopInfo/phi_not_grouped_at_top.ll:1
-; RUN: opt %loadPolly -analyze  < %s
+; RUN: opt %loadPolly < %s
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
----------------
This test doesn't anything. It once used the `-polly-prepare` which has been erroneously removed in rL240766. I suggest to re-add it again, although the code this was testing was removed since, making the entire test obsolete.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94266/new/

https://reviews.llvm.org/D94266