[PATCH] D94972: [SLP]Need to shrink the load vector after reordering.

Tue Jan 19 10:42:20 PST 2021

echristo added a comment.

In D94972#2507400 <https://reviews.llvm.org/D94972#2507400>, @ABataev wrote:

> In D94972#2507385 <https://reviews.llvm.org/D94972#2507385>, @echristo wrote:
>
>> Hard to tell because there aren't any comments around any of the code that changed in either patch. Can you fix that in a separate change and actually document what everything is doing? :)
>
> This is a separate patch with the fix only. :) There are no more patches required to fix the issue, just this one. Or do you mean something else?

The previous patch.. and yeah, I know it's not your fault some of this could be better documented and thanks for fixing it up :)

>> For this patch can you add a comment that explains what we're doing here as well. It's unclear.
>
> Sure.

Thanks!

-eric

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94972/new/

https://reviews.llvm.org/D94972