[PATCH] D94972: [SLP]Need to shrink the load vector after reordering.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 19 10:39:45 PST 2021


ABataev added a comment.

In D94972#2507385 <https://reviews.llvm.org/D94972#2507385>, @echristo wrote:

> Hard to tell because there aren't any comments around any of the code that changed in either patch. Can you fix that in a separate change and actually document what everything is doing? :)

This is a separate patch with the fix only. :) There are no more patches required to fix the issue, just this one. Or do you mean something else?

> For this patch can you add a comment that explains what we're doing here as well. It's unclear.

Sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94972/new/

https://reviews.llvm.org/D94972



More information about the llvm-commits mailing list