[PATCH] D94590: [RISCV] Add ISel patterns for scalable mask exts & truncs

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck marked an inline comment as done.
frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1229
+  // Only custom-lower extensions from mask types
+  if (!VecVT.isVector() || !Src.getValueType().isVector() ||
+      Src.getValueType().getVectorElementType() != MVT::i1)
----------------
craig.topper wrote:
> Why do we need to check that both VecVT and Src.getValueType() are vectors? Don't they always match?
I'd sure hope so. I think I generally tend towards avoiding making assumptions but I see how that often results in redundancy. We'd be in a pickle if the types didn't match up. I'll fix that up before pushing. Cheers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94590/new/

https://reviews.llvm.org/D94590