[PATCH] D94585: [IndirectFunctions] Skip propagating attributes to address taken functions

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPropagateAttributes.cpp:242
+      if (F.hasAddressTaken())
+        continue;
+
----------------
madhur13490 wrote:
> rampitec wrote:
> > I think you still need to add it to NewRoots to propagate from F down the stack.
> I don't think that is needed. The address taken functions will neither have features not attributes to no need to propagate them to their callees. If a function is called from both address taken function and a non-address taken function then the traversal would address that.
I'd say never say never. You had a proper and simple code to add it the roots in this if() block.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94585/new/

https://reviews.llvm.org/D94585