[PATCH] D94585: [IndirectFunctions] Skip propagating attributes to address taken functions

[Madhur Amilkanthwar via Phabricator via llvm-commits]

madhur13490 added a comment.

Bump!



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPropagateAttributes.cpp:242
+      if (F.hasAddressTaken())
+        continue;
+
----------------
rampitec wrote:
> I think you still need to add it to NewRoots to propagate from F down the stack.
I don't think that is needed. The address taken functions will neither have features not attributes to no need to propagate them to their callees. If a function is called from both address taken function and a non-address taken function then the traversal would address that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94585/new/

https://reviews.llvm.org/D94585